From d7c7d1d2c89f961e1aa85c6d1bc136687d4dd99d Mon Sep 17 00:00:00 2001 From: Brian Coca Date: Fri, 3 Jun 2022 18:39:01 -0400 Subject: [PATCH 1/2] More complete missing lib msg adds 'exact' python used by module and hostname to avoid confusion --- plugins/module_utils/firewalld.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/module_utils/firewalld.py b/plugins/module_utils/firewalld.py index c79a126..6a76c32 100644 --- a/plugins/module_utils/firewalld.py +++ b/plugins/module_utils/firewalld.py @@ -5,6 +5,7 @@ from __future__ import absolute_import, division, print_function from ansible_collections.ansible.posix.plugins.module_utils.version import LooseVersion +from ansible.module_utils.basic import missing_required_lib __metaclass__ = type @@ -314,6 +315,5 @@ class FirewallTransaction(object): if import_failure: module.fail_json( - msg='Python Module not found: firewalld and its python module are required for this module, \ - version 0.2.11 or newer required (0.3.9 or newer for offline operations)' + msg=missing_required_lib('firewall') + '. Version 0.2.11 or newer required (0.3.9 or newer for offline operations)' ) From cc20deaad240e24e0083b3d1c6589ad833c040f6 Mon Sep 17 00:00:00 2001 From: Hideki Saito Date: Fri, 16 Sep 2022 16:37:23 +0900 Subject: [PATCH 2/2] Add changelog fragment file to PR #373 Signed-off-by: Hideki Saito --- .../fragments/373_firewall_fix_missing_library_message.yml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 changelogs/fragments/373_firewall_fix_missing_library_message.yml diff --git a/changelogs/fragments/373_firewall_fix_missing_library_message.yml b/changelogs/fragments/373_firewall_fix_missing_library_message.yml new file mode 100644 index 0000000..a5faea8 --- /dev/null +++ b/changelogs/fragments/373_firewall_fix_missing_library_message.yml @@ -0,0 +1,3 @@ +--- +bugfixes: + - firewall - Fixed to output a more complete missing library message.