From 2351c27339a05f6b6e74ebf3a003b852068a6c75 Mon Sep 17 00:00:00 2001 From: "softwarefactory-project-zuul[bot]" <33884098+softwarefactory-project-zuul[bot]@users.noreply.github.com> Date: Tue, 8 Jul 2025 05:47:53 +0000 Subject: [PATCH] Merge pull request #650 from felixfontein/callback profile_* callbacks: avoid deprecated/deleted functions SUMMARY The profile_roles and profile_tasks callbacks define methods playbook_on_setup and playbook_on_stats which have been deleted/deprecated: playbook_on_stats has been deprecated, v2_playbook_on_stats should be used instead (that one has already been there for many years: ansible/ansible@ba0e532 was added in 2015). playbook_on_setup has been deleted (ansible/ansible@eec57ec), and its v2 variant was already deleted in 2017: ansible/ansible@59d5481 Ref: #635 ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME profile_roles profile_tasks Reviewed-by: Abhijeet Kasurde Reviewed-by: Hideki Saito --- changelogs/fragments/650-profile_tasks_roles.yml | 2 ++ plugins/callback/profile_roles.py | 5 +---- plugins/callback/profile_tasks.py | 5 +---- 3 files changed, 4 insertions(+), 8 deletions(-) create mode 100644 changelogs/fragments/650-profile_tasks_roles.yml diff --git a/changelogs/fragments/650-profile_tasks_roles.yml b/changelogs/fragments/650-profile_tasks_roles.yml new file mode 100644 index 0000000..d8664b8 --- /dev/null +++ b/changelogs/fragments/650-profile_tasks_roles.yml @@ -0,0 +1,2 @@ +minor_changes: + - "profile_tasks and profile_roles callback plugins - avoid deleted/deprecated callback functions, instead use modern interface that was introduced a longer time ago (https://github.com/ansible-collections/ansible.posix/issues/650)." diff --git a/plugins/callback/profile_roles.py b/plugins/callback/profile_roles.py index 270a74f..4d58014 100644 --- a/plugins/callback/profile_roles.py +++ b/plugins/callback/profile_roles.py @@ -124,10 +124,7 @@ class CallbackModule(CallbackBase): def v2_playbook_on_handler_task_start(self, task): self._record_task(task) - def playbook_on_setup(self): - self._display_tasktime() - - def playbook_on_stats(self, stats): + def v2_playbook_on_stats(self, stats): # Align summary report header with other callback plugin summary self._display.banner("ROLES RECAP") diff --git a/plugins/callback/profile_tasks.py b/plugins/callback/profile_tasks.py index c5cc5fe..c5857ca 100644 --- a/plugins/callback/profile_tasks.py +++ b/plugins/callback/profile_tasks.py @@ -189,10 +189,7 @@ class CallbackModule(CallbackBase): def v2_playbook_on_handler_task_start(self, task): self._record_task(task) - def playbook_on_setup(self): - self._display_tasktime() - - def playbook_on_stats(self, stats): + def v2_playbook_on_stats(self, stats): # Align summary report header with other callback plugin summary self._display.banner("TASKS RECAP")