From 42f7d48d73f23b11432d08761fbb75c169241ad2 Mon Sep 17 00:00:00 2001 From: Michael <35783820+mib1185@users.noreply.github.com> Date: Thu, 26 Oct 2023 15:42:47 +0200 Subject: [PATCH 1/2] warn only when zones were ignored --- plugins/modules/firewalld_info.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/modules/firewalld_info.py b/plugins/modules/firewalld_info.py index 8b5c80c..c83437d 100644 --- a/plugins/modules/firewalld_info.py +++ b/plugins/modules/firewalld_info.py @@ -356,8 +356,9 @@ def main(): specified_zones = module.params['zones'] collect_zones = list(set(specified_zones) & set(all_zones)) ignore_zones = list(set(specified_zones) - set(collect_zones)) - warn.append( - 'Please note: zone:(%s) have been ignored in the gathering process.' % ','.join(ignore_zones)) + if ignore_zones: + warn.append( + 'Please note: zone:(%s) have been ignored in the gathering process.' % ','.join(ignore_zones)) else: collect_zones = get_all_zones(client) From 2990582b4164a2da5aac5f259b5463403c5b5236 Mon Sep 17 00:00:00 2001 From: mib1185 Date: Sat, 16 Dec 2023 18:53:26 +0100 Subject: [PATCH 2/2] add changelog 504-firewalld_info-warning --- changelogs/fragments/504-firewalld_info-warning.yaml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/504-firewalld_info-warning.yaml diff --git a/changelogs/fragments/504-firewalld_info-warning.yaml b/changelogs/fragments/504-firewalld_info-warning.yaml new file mode 100644 index 0000000..73e00aa --- /dev/null +++ b/changelogs/fragments/504-firewalld_info-warning.yaml @@ -0,0 +1,2 @@ +minor_changes: + - firewalld_info - Only warn about ignored zones, when there are zones ignored.