diff --git a/changelogs/fragments/504-firewalld_info-warning b/changelogs/fragments/504-firewalld_info-warning new file mode 100644 index 0000000..521f13f --- /dev/null +++ b/changelogs/fragments/504-firewalld_info-warning @@ -0,0 +1,3 @@ +--- +trivial: + - Only warn about ignored zones in firewalld_info, when there are zones ignored diff --git a/plugins/modules/firewalld_info.py b/plugins/modules/firewalld_info.py index 334518d..09d337b 100644 --- a/plugins/modules/firewalld_info.py +++ b/plugins/modules/firewalld_info.py @@ -349,8 +349,9 @@ def main(): specified_zones = module.params['zones'] collect_zones = list(set(specified_zones) & set(all_zones)) ignore_zones = list(set(specified_zones) - set(collect_zones)) - warn.append( - 'Please note: zone:(%s) have been ignored in the gathering process.' % ','.join(ignore_zones)) + if ignore_zones: + warn.append( + 'Please note: zone:(%s) have been ignored in the gathering process.' % ','.join(ignore_zones)) else: collect_zones = get_all_zones(client)