From 07f1e11015658f87aed1cc5bb205989a626c871f Mon Sep 17 00:00:00 2001 From: Adam Miller Date: Fri, 5 May 2023 11:59:04 -0500 Subject: [PATCH 1/2] fix sysctl integration test failing on newer versions of core Previously NoneType was allowable, now it fails to convert to a str type. Signed-off-by: Adam Miller --- tests/integration/targets/sysctl/tasks/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/integration/targets/sysctl/tasks/main.yml b/tests/integration/targets/sysctl/tasks/main.yml index c9a63c4..0c40fc3 100644 --- a/tests/integration/targets/sysctl/tasks/main.yml +++ b/tests/integration/targets/sysctl/tasks/main.yml @@ -170,7 +170,7 @@ - name: Try sysctl with no name sysctl: - name: + name: "" value: 1 sysctl_set: yes ignore_errors: True @@ -180,7 +180,7 @@ assert: that: - sysctl_no_name is failed - - "sysctl_no_name.msg == 'name cannot be None'" + - "sysctl_no_name.msg == 'name cannot be blank'" - name: Try sysctl with no value sysctl: From 4f46ff218fd55db68e42e18c61f98a0dc0e99e4e Mon Sep 17 00:00:00 2001 From: Adam Miller Date: Fri, 5 May 2023 12:02:54 -0500 Subject: [PATCH 2/2] add changelog fragment Signed-off-by: Adam Miller --- changelogs/fragments/456_sysctl_fix_nonetype.yml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 changelogs/fragments/456_sysctl_fix_nonetype.yml diff --git a/changelogs/fragments/456_sysctl_fix_nonetype.yml b/changelogs/fragments/456_sysctl_fix_nonetype.yml new file mode 100644 index 0000000..0bcb27f --- /dev/null +++ b/changelogs/fragments/456_sysctl_fix_nonetype.yml @@ -0,0 +1,3 @@ +--- +bugfixes: + - "Fix sysctl integration test failing on newer versions of core. Previously NoneType was allowable, now it fails to convert to a str type."