From b8b424e4ee04124813fc97f022f8e2b9353ccbb5 Mon Sep 17 00:00:00 2001 From: Pavel Bar Date: Sun, 15 Feb 2026 22:56:50 +0200 Subject: [PATCH] Fix deprecated imports in plugins/modules/sysctl.py Replace deprecated module_utils imports: - ansible.module_utils._text -> ansible.module_utils.common.text.converters - ansible.module_utils.six.string_types -> str Fixes #686 Co-authored-by: Cursor AI Signed-off-by: Pavel Bar --- plugins/modules/sysctl.py | 5 ++--- tests/sanity/ignore-2.21.txt | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/modules/sysctl.py b/plugins/modules/sysctl.py index 86712db..b85ac2d 100644 --- a/plugins/modules/sysctl.py +++ b/plugins/modules/sysctl.py @@ -110,9 +110,8 @@ import re import tempfile from ansible.module_utils.basic import AnsibleModule -from ansible.module_utils.six import string_types +from ansible.module_utils.common.text.converters import to_native from ansible.module_utils.parsing.convert_bool import BOOLEANS_FALSE, BOOLEANS_TRUE -from ansible.module_utils._text import to_native class SysctlModule(object): @@ -224,7 +223,7 @@ class SysctlModule(object): return '1' else: return '0' - elif isinstance(value, string_types): + elif isinstance(value, str): if value.lower() in BOOLEANS_TRUE: return '1' elif value.lower() in BOOLEANS_FALSE: diff --git a/tests/sanity/ignore-2.21.txt b/tests/sanity/ignore-2.21.txt index a261578..17e042d 100644 --- a/tests/sanity/ignore-2.21.txt +++ b/tests/sanity/ignore-2.21.txt @@ -1,5 +1,4 @@ tests/utils/shippable/timing.py shebang -plugins/modules/sysctl.py pylint:ansible-bad-import-from plugins/shell/csh.py pylint:ansible-bad-import-from plugins/shell/fish.py pylint:ansible-bad-import-from tests/unit/mock/procenv.py pylint:ansible-bad-import-from