From c319c856ed12650e0f5d5d070c8689b8275297ff Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Sat, 28 Jun 2025 16:29:29 +0200 Subject: [PATCH 1/2] Avoid deprecated/deleted callback functions. --- plugins/callback/profile_roles.py | 5 +---- plugins/callback/profile_tasks.py | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/plugins/callback/profile_roles.py b/plugins/callback/profile_roles.py index 270a74f..4d58014 100644 --- a/plugins/callback/profile_roles.py +++ b/plugins/callback/profile_roles.py @@ -124,10 +124,7 @@ class CallbackModule(CallbackBase): def v2_playbook_on_handler_task_start(self, task): self._record_task(task) - def playbook_on_setup(self): - self._display_tasktime() - - def playbook_on_stats(self, stats): + def v2_playbook_on_stats(self, stats): # Align summary report header with other callback plugin summary self._display.banner("ROLES RECAP") diff --git a/plugins/callback/profile_tasks.py b/plugins/callback/profile_tasks.py index 7cce85a..2945bf9 100644 --- a/plugins/callback/profile_tasks.py +++ b/plugins/callback/profile_tasks.py @@ -209,10 +209,7 @@ class CallbackModule(CallbackBase): def v2_playbook_on_handler_task_start(self, task): self._record_task(task) - def playbook_on_setup(self): - self._display_tasktime() - - def playbook_on_stats(self, stats): + def v2_playbook_on_stats(self, stats): # Align summary report header with other callback plugin summary self._display.banner("TASKS RECAP") From f9789985211b6165ad6f0cb07a6fa4c2f256f239 Mon Sep 17 00:00:00 2001 From: Felix Fontein Date: Sat, 28 Jun 2025 16:34:47 +0200 Subject: [PATCH 2/2] Add changelog fragment. --- changelogs/fragments/650-profile_tasks_roles.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/650-profile_tasks_roles.yml diff --git a/changelogs/fragments/650-profile_tasks_roles.yml b/changelogs/fragments/650-profile_tasks_roles.yml new file mode 100644 index 0000000..d8664b8 --- /dev/null +++ b/changelogs/fragments/650-profile_tasks_roles.yml @@ -0,0 +1,2 @@ +minor_changes: + - "profile_tasks and profile_roles callback plugins - avoid deleted/deprecated callback functions, instead use modern interface that was introduced a longer time ago (https://github.com/ansible-collections/ansible.posix/issues/650)."