From 7d928e6e9dc65f4f900d613361a2da6c9798f555 Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Fri, 4 Jun 2021 11:38:14 +0530 Subject: [PATCH 1/2] synchronize: fix misc typo Docs should read ``--delete-after`` instead of ``--delete-excluded``. Fixes: #175 Signed-off-by: Abhijeet Kasurde --- changelogs/fragments/175_synchronize.yml | 3 +++ plugins/modules/synchronize.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/175_synchronize.yml diff --git a/changelogs/fragments/175_synchronize.yml b/changelogs/fragments/175_synchronize.yml new file mode 100644 index 0000000..4d1a161 --- /dev/null +++ b/changelogs/fragments/175_synchronize.yml @@ -0,0 +1,3 @@ +--- +trivial: +- synchronize - fix typo in ``delete`` parameter (https://github.com/ansible-collections/ansible.posix/issues/175). diff --git a/plugins/modules/synchronize.py b/plugins/modules/synchronize.py index dafaf78..2fcb7a4 100644 --- a/plugins/modules/synchronize.py +++ b/plugins/modules/synchronize.py @@ -75,7 +75,7 @@ options: description: - Delete files in C(dest) that don't exist (after transfer, not before) in the C(src) path. - This option requires C(recursive=yes). - - This option ignores excluded files and behaves like the rsync opt --delete-excluded. + - This option ignores excluded files and behaves like the rsync opt --delete-after. type: bool default: no dirs: From 7bed8ce79e7624a9c19cc61fda73fee949f3e196 Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Fri, 4 Jun 2021 18:39:50 +0530 Subject: [PATCH 2/2] review requests Signed-off-by: Abhijeet Kasurde --- plugins/modules/synchronize.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/modules/synchronize.py b/plugins/modules/synchronize.py index 2fcb7a4..2676275 100644 --- a/plugins/modules/synchronize.py +++ b/plugins/modules/synchronize.py @@ -73,9 +73,9 @@ options: default: no delete: description: - - Delete files in C(dest) that don't exist (after transfer, not before) in the C(src) path. - - This option requires C(recursive=yes). - - This option ignores excluded files and behaves like the rsync opt --delete-after. + - Delete files in I(dest) that do not exist (after transfer, not before) in the I(src) path. + - This option requires I(recursive=yes). + - This option ignores excluded files and behaves like the rsync opt C(--delete-after). type: bool default: no dirs: