Apply suggestions from code review

Thanks felixfontein for the thorough review. :-)

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Alexei Znamensky 2024-06-09 11:49:33 +12:00 committed by Alexei Znamensky
parent 0c9ab06a55
commit ef07eb8a06
5 changed files with 10 additions and 10 deletions

View file

@ -86,7 +86,7 @@ options:
description: description:
- Whether to apply this change to the permanent firewalld configuration. - Whether to apply this change to the permanent firewalld configuration.
- As of Ansible 2.3, permanent operations can operate on firewalld configs when it is not running (requires firewalld >= 0.3.9). - As of Ansible 2.3, permanent operations can operate on firewalld configs when it is not running (requires firewalld >= 0.3.9).
- Note that if this is V(false), O(immediate=true). - Note that if this is V(false), O(immediate=true) by default.
type: bool type: bool
default: false default: false
immediate: immediate:

View file

@ -24,20 +24,20 @@ options:
path: path:
description: description:
- Path to the mount point (e.g. C(/mnt/files)). - Path to the mount point (e.g. C(/mnt/files)).
- Before Ansible 2.3 this option was only usable as O(ignore:dest), O(ignore:destfile) and O(name). - Before Ansible 2.3 this option was only usable as O(ignore:dest), O(ignore:destfile), and O(name).
type: path type: path
required: true required: true
aliases: [ name ] aliases: [ name ]
src: src:
description: description:
- Device (or NFS volume, or something else) to be mounted on I(path). - Device (or NFS volume, or something else) to be mounted on I(path).
- Required when O(state) set to V(present), V(mounted) or V(ephemeral). - Required when O(state) set to V(present), V(mounted), or V(ephemeral).
- Ignored when O(state) set to V(absent) or V(unmounted). - Ignored when O(state) set to V(absent) or V(unmounted).
type: path type: path
fstype: fstype:
description: description:
- Filesystem type. - Filesystem type.
- Required when O(state) is V(present), V(mounted) or V(ephemeral). - Required when O(state) is V(present), V(mounted), or V(ephemeral).
type: str type: str
opts: opts:
description: description:
@ -71,7 +71,7 @@ options:
I(fstab) and does not trigger or require a mount. I(fstab) and does not trigger or require a mount.
- V(ephemeral) only specifies that the device is to be mounted, without changing - V(ephemeral) only specifies that the device is to be mounted, without changing
I(fstab). If it is already mounted, a remount will be triggered. I(fstab). If it is already mounted, a remount will be triggered.
This will always return RV(ignore:changed=True). If the mount point O(path) This will always return RV(ignore:changed=true). If the mount point O(path)
has already a device mounted on, and its source is different than O(src), has already a device mounted on, and its source is different than O(src),
the module will fail to avoid unexpected unmount or mount point override. the module will fail to avoid unexpected unmount or mount point override.
If the mount point is not present, the mount point will be created. If the mount point is not present, the mount point will be created.

View file

@ -52,7 +52,7 @@ options:
default: push default: push
archive: archive:
description: description:
- Mirrors the rsync archive flag, enables recursive, links, perms, times, owner, group flags and C(-D). - Mirrors the rsync archive flag, enables recursive, links, perms, times, owner, group flags, and C(-D).
type: bool type: bool
default: true default: true
checksum: checksum:
@ -207,8 +207,8 @@ options:
notes: notes:
- C(rsync) must be installed on both the local and remote host. - C(rsync) must be installed on both the local and remote host.
- For the M(ansible.posix.synchronize) module, the "local host" is the host `the synchronize task originates on`, - For the M(ansible.posix.synchronize) module, the "local host" is the host I(the synchronize task originates on),
and the "destination host" is the host `synchronize is connecting to`. and the "destination host" is the host I(synchronize is connecting to).
- The "local host" can be changed to a different host by using C(delegate_to). - The "local host" can be changed to a different host by using C(delegate_to).
This enables copying between two remote hosts or entirely on one remote machine. This enables copying between two remote hosts or entirely on one remote machine.
- > - >

View file

@ -43,7 +43,7 @@ options:
description: description:
- If V(true), performs a C(/sbin/sysctl -p) if the O(sysctl_file) is - If V(true), performs a C(/sbin/sysctl -p) if the O(sysctl_file) is
updated. If V(false), does not reload C(sysctl) even if the updated. If V(false), does not reload C(sysctl) even if the
C(sysctl_file) is updated. O(sysctl_file) is updated.
type: bool type: bool
default: true default: true
sysctl_file: sysctl_file: