From 39930cac21fbbc2b1891a41dd523980b8a7242e9 Mon Sep 17 00:00:00 2001 From: mandar Date: Tue, 13 Jul 2021 18:08:26 -0400 Subject: [PATCH] Adding tests, corrections --- .../220_synchronize_add_quiet_option.yml | 2 +- plugins/modules/synchronize.py | 6 ++-- .../targets/synchronize/tasks/main.yml | 33 +++++++++++++++++++ 3 files changed, 37 insertions(+), 4 deletions(-) diff --git a/changelogs/fragments/220_synchronize_add_quiet_option.yml b/changelogs/fragments/220_synchronize_add_quiet_option.yml index a9a7cb1..e64a50c 100644 --- a/changelogs/fragments/220_synchronize_add_quiet_option.yml +++ b/changelogs/fragments/220_synchronize_add_quiet_option.yml @@ -1,2 +1,2 @@ minor_changes: -- synchronize - add the ``quiet`` option to supress non-error messages (https://github.com/ansible-collections/ansible.posix/issues/171). +- synchronize - add the ``quiet`` option to suppress non-error messages (https://github.com/ansible-collections/ansible.posix/issues/171). diff --git a/plugins/modules/synchronize.py b/plugins/modules/synchronize.py index 9cc5fdc..71bbe91 100644 --- a/plugins/modules/synchronize.py +++ b/plugins/modules/synchronize.py @@ -186,7 +186,7 @@ options: version_added: '1.3.0' quiet: description: - - This specifies rsync quiet option which on yes/true suppresses the non-error messages + - This specifies rsync quiet option which on yes/true suppresses the non-error messages. type: bool default: no version_added: '1.3.0' @@ -429,7 +429,7 @@ def main(): delay_updates=dict(type='bool', default=True), mode=dict(type='str', default='push', choices=['pull', 'push']), link_dest=dict(type='list', elements='str'), - quiet=dict(type='bool',default=False) + quiet=dict(type='bool', default=False) ), supports_check_mode=True, ) @@ -600,7 +600,7 @@ def main(): dest = os.path.expanduser(dest) if quiet: - cmd.append('--quiet') + cmd.append('--quiet') cmd.append(source) cmd.append(dest) diff --git a/tests/integration/targets/synchronize/tasks/main.yml b/tests/integration/targets/synchronize/tasks/main.yml index ac1aa03..0814728 100644 --- a/tests/integration/targets/synchronize/tasks/main.yml +++ b/tests/integration/targets/synchronize/tasks/main.yml @@ -227,3 +227,36 @@ - directory_a/foo.txt - directory_a - directory_b +- name: synchronize files with quiet option + synchronize: + src: '{{output_dir}}/foo.txt' + dest: '{{output_dir}}/foo.result' + quiet: true + register: sync_result + ignore_errors: true +- assert: + that: + - '''--quiet'' in sync_result.cmd' +- name: Cleanup + file: + state: absent + path: '{{output_dir}}/{{item}}' + with_items: + - foo.result + - bar.result +- name: synchronize files without quiet option + synchronize: + src: '{{output_dir}}/foo.txt' + dest: '{{output_dir}}/foo.result' + register: sync_result + ignore_errors: true +- assert: + that: + - '''--quiet'' not in sync_result.cmd' +- name: Cleanup + file: + state: absent + path: '{{output_dir}}/{{item}}' + with_items: + - foo.result + - bar.result