carroarmato0/ansible.posix
1
0
Fork 0
mirror of https://github.com/ansible-collections/ansible.posix.git synced 2026-01-11 23:25:28 +01:00
Code Issues Projects Releases Packages Wiki Activity
231 commits 3 branches 18 tags 6.5 MiB
Commit graph

95 commits

Author SHA1 Message Date
Sagi Shnaidman
133ffe51fb Complete adding podman connection to synchronize 2021-08-03 15:44:00 +03:00
Sagi Shnaidman
c5d49b2a91 Allow podman connections in synchronize module 2021-07-23 14:29:02 +03:00
ansible-zuul[bot]
a03e652437
Merge pull request #214 from saito-hideki/pr/add_firewalld_info 
Add new firewalld_info module to ansible.posix collection

SUMMARY
Add new firewalld_info module to ansible.posix collection.

Gathering information about firewalld zone settings
fixes #98

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ansible.posix.firewalld_info

ADDITIONAL INFORMATION
None

Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: Hideki Saito <saito@fgrep.org>
 2021-07-21 05:19:13 +00:00
ansible-zuul[bot]
e815909859
Merge pull request #215 from quasd/main 
fix REJECT target name

SUMMARY
Fix setting default target to reject. The target name is %%REJECT%% not REJECT.
https://firewalld.org/documentation/zone/options.html
After this pull request to way to set REJECT would be
  - name: "Set target to REJECT for public"
    ansible.posix.firewalld:
      zone: public
      permanent: yes
      target: '%%REJECT%%'
      state: enabled
    become: true


ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
firewalld
ADDITIONAL INFORMATION



This snippet would fail due to there not being target called REJECT and using %%REJECT%% is not in allowed values for target
  - name: "Set target to REJECT for public"
    ansible.posix.firewalld:
      zone: public
      permanent: yes
      target: 'REJECT'
      state: enabled
    become: true

Ansible error
{
    "msg": "ERROR: Exception caught: org.fedoraproject.FirewallD1.Exception: INVALID_TARGET: REJECT Permanent operation",
    "invocation": {
        "module_args": {
            "zone": "public",
            "permanent": true,
            "target": "REJECT",
            "state": "enabled",
            "immediate": false,
            "timeout": 0,
            "icmp_block": null,
            "icmp_block_inversion": null,
            "service": null,
            "port": null,
            "port_forward": null,
            "rich_rule": null,
            "source": null,
            "interface": null,
            "masquerade": null,
            "offline": null
        }
    },
    "_ansible_no_log": false,
    "changed": false
}

syslog
Jun 29 09:49:39 <hostname retracted> ansible-ansible.posix.firewalld[9015]: Invoked with zone=public permanent=True state=enabled target=REJECT immediate=False timeout=0 icmp_[1850/7279] icmp_block_inversion=None service=None port=None port_forward=None rich_rule=None source=None interface=None masquerade=None offline=None                                                                 
Jun 29 09:49:39 <hostname retracted>  firewalld[915]: ERROR: INVALID_TARGET: REJECT

Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: None <None>
Reviewed-by: Amin Vakil <info@aminvakil.com>
Reviewed-by: quidame <None>
Reviewed-by: Hideki Saito <saito@fgrep.org>
 2021-07-14 17:05:30 +00:00
ansible-zuul[bot]
f2601b01da
Merge pull request #213 from ndgit/fix-24-and-190 
synchronize: quotes around arguments

fix quoting for specific cmd arguments
Fixes:

#24
#190

ISSUE TYPE:

Bugfix Pull Request

COMPONENT NAME:
module: synchronize

Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: Robert Rettig <None>
Reviewed-by: Hideki Saito <saito@fgrep.org>
Reviewed-by: Mike Graves <mgraves@redhat.com>
 2021-07-14 15:20:20 +00:00
Hideki Saito
27434455e5 Add new firewalld_info module to ansible.posix collection 
* fixes #98

Signed-off-by: Hideki Saito <saito@fgrep.org>
 2021-07-09 23:47:12 +09:00
ansible-zuul[bot]
f6fa00bfff
Merge pull request #187 from smemsh/fix-synchronize-become-user 
synchronize: fix to honor become_user when become_method sudo

SUMMARY

When become_method is sudo, the synchronize module ignores become_user, always running as root.  This means one cannot create files as a target user, when they need to get in via a third user and can only sudo via that one.  In my case, I'm connecting via a special provisioning user that has sudo privs, but I need to create the files as the become_user.  I'm using it to deposit skeleton files, and there should be no reason to run another task with chown; after all, the documentation already describes the desired behavior:

The user and permissions for the synchronize dest are those of the remote_user on the destination host or the become_user if become=yes is active.

This patch takes the running become_user (if it's not None) and adds it to the sudo command with the -u command line option, so the file gets created correctly.  I have tested this and it works.
Other become_methods are ignored, but they already were anyways (the code already has a TODO to add other methods, which we don't attempt in this patch)
Fixes #186

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

synchronize
ADDITIONAL INFORMATION


See reproduction in #186.
This appears to have been in place since ansible/ansible@811a906

Reviewed-by: Amin Vakil <info@aminvakil.com>
Reviewed-by: Sumit Jaiswal <sjaiswal@redhat.com>
 2021-07-08 14:16:12 +00:00
Mandar Kulkarni
b740bdaf3a Merge https://github.com/ansible-collections/ansible.posix into issues/126/mount-return-backup-file 2021-06-30 04:11:28 -04:00
quasd
049292669b fix yaml syntax for reject choices 2021-06-29 13:33:35 +03:00
Erkki Hurme
757b544cf3 fix REJECT target name 2021-06-29 10:38:47 +03:00
Robert Rettig
0118bf0cb9 fixes #24 and #190 2021-06-24 23:37:48 +02:00
ansible-zuul[bot]
a994a58b23
Merge pull request #203 from saito-hideki/issue/28_bsd 
Modify boot option handling on BSD systems

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-06-16 11:30:20 +00:00
ansible-zuul[bot]
e2a316122a
Merge pull request #199 from Akasurde/i179 
firewalld: Ensure idempotency

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-06-11 11:35:12 +00:00
ansible-zuul[bot]
e068522325
Merge pull request #205 from Akasurde/i204 
csh: Define ``ECHO`` and ``COMMAND_SEP``

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-06-09 17:28:12 +00:00
Abhijeet Kasurde
51d117285f csh: Define `ECHO and COMMAND_SEP` 
Fixes: #204

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2021-06-09 17:46:09 +05:30
Hideki Saito
c29bbd265b Modify boot option handling on BSD systems 
* Fixes #28 for BSD systems
* Porting PR #196 to BSD systems

Signed-off-by: Hideki Saito <saito@fgrep.org>
 2021-06-08 20:44:42 +09:00
ansible-zuul[bot]
7417d857f1
Merge pull request #202 from Akasurde/i124 
acl: Add new alias

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-06-07 07:57:33 +00:00
ansible-zuul[bot]
ceddb849b8
Merge pull request #201 from Akasurde/i175 
synchronize: fix misc typo

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-06-04 15:49:36 +00:00
ansible-zuul[bot]
f5666924ab
Merge pull request #200 from Akasurde/i193 
firewalld: Specify unit for timeout

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-06-04 13:36:59 +00:00
Abhijeet Kasurde
7bed8ce79e review requests 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2021-06-04 18:39:50 +05:30
Abhijeet Kasurde
7d928e6e9d synchronize: fix misc typo 
Docs should read ``--delete-after`` instead of ``--delete-excluded``.

Fixes: #175

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2021-06-04 18:38:01 +05:30
Abhijeet Kasurde
07fe3a91b6 firewalld: Ensure idempotency 
Use APIs like ``query*`` instead of ``get*``.

Fixes: #179

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2021-06-04 16:55:19 +05:30
Abhijeet Kasurde
5cebc90623 firewalld: Specify unit for timeout 
Timeout parameter takes value which is specified in seconds.

Fixes: #193

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2021-06-04 16:53:37 +05:30
Abhijeet Kasurde
6ba8445fb1 acl: Add new alias 
Added new alias ``recurse`` for parameter ``recursive``.

Fixes: #124

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2021-06-04 16:51:15 +05:30
ansible-zuul[bot]
9d4ae8b7e4
Merge pull request #196 from saito-hideki/issue/28 
Modify boot option handling on Linux systems

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-06-04 06:23:07 +00:00
Adam Miller
41e5b8428f mount return backup_file 
Fixes https://github.com/ansible-collections/ansible.posix/issues/126

Signed-off-by: Adam Miller <admiller@redhat.com>
 2021-06-04 10:52:38 +05:30
ansible-zuul[bot]
1793cd70c4
Merge pull request #172 from saito-hideki/issue/169 
Append line-separator to the end of command line

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-06-03 12:02:30 +00:00
Abhijeet Kasurde
5d0c5ae3a6 synchronize: correct typo 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2021-06-02 12:58:56 +05:30
Hideki Saito
cfff8a3806 Modify boot option handling on Linux systems 
* Address the issue #28
* Modified behavior to set noauto option if boot is 'no' on Linux system
* Modified integration test to use filesize module instead of dd

Signed-off-by: Hideki Saito <saito@fgrep.org>
 2021-06-01 14:21:01 +09:00
ansible-zuul[bot]
7e6adc977f
Merge pull request #167 from aminvakil/rsync_hardcoded_options 
synchronize: add delay_updates option

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-05-31 12:44:36 +00:00
Amin Vakil
54ea8777f8
add version_added to new option 
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
 2021-05-27 19:31:40 +04:30
ansible-zuul[bot]
5d0c8e40d8
Merge pull request #185 from saito-hideki/issue/184 
[mount] Fix boot option handling on Solaris correctly

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-05-27 08:20:32 +00:00
ansible-zuul[bot]
eaf3d666cc
Merge pull request #189 from Akasurde/i134 
authorized_key: Add support for additional key types

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-05-27 06:24:03 +00:00
Abhijeet Kasurde
c985096af5 authorized_key: Add support for additional key types 
Fixes: #134

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2021-05-25 10:06:01 +05:30
Hideki Saito
0bef7bb164 Fix boot option handling on Solaris correctly 
* Fixes #184

Signed-off-by: Hideki Saito <saito@fgrep.org>
 2021-05-13 15:12:50 +09:00
Scott Mcdermott
6b41ce1a9d Fix to honor become_user in synchronize module (Fixes #186) 2021-05-12 01:00:17 -07:00
Hideki Saito
13e77fd7da Append line-separator to the end of command line 
* Addresses issue #169 (https://github.com/ansible-collections/ansible.posix/issues/169)

Signed-off-by: Hideki Saito <saito@fgrep.org>
 2021-05-05 09:35:39 +09:00
Amin Vakil
9313bf3e68
Reorder if to address quidame suggestion 2021-04-26 10:58:27 +04:30
Amin Vakil
7511421440
Add delay_updates option to synchronize module 2021-04-03 16:22:10 +04:30
quidame
d976add5da replace no more supported 'ansible_ssh_*' option names by the new ones 
* Replace 'ansible_ssh_user' by 'ansible_user' everywhere.
* Replace 'ansible_ssh_port' by 'ansible_port' everywhere.
* Replace 'ansible_ssh_host' by 'ansible_host' everywhere.
 2021-03-28 13:50:49 +02:00
quidame
c8b58875d9 add no_log=False to clear false-positives 
Related modules: authorized_key, mount.
 2021-03-19 09:07:14 +01:00
ansible-zuul[bot]
252b531c20
Merge pull request #120 from pneerincx/bugfix_for_24365 
Bugfix for #24365: "Added option to allow SSH connection multiplexing"

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-03-05 18:30:48 +00:00
ansible-zuul[bot]
bc88258687
Merge pull request #118 from pneerincx/bugfix_for_17492 
Bugfix for #17492 "Do not prepend PWD when path is in form user@server:path or server:path" 

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-03-05 18:26:53 +00:00
ansible-zuul[bot]
1747370f30
Merge pull request #144 from xlab-steampunk/teach-synchronize-about-community-docker 
Inform synchronize module about community.docker collection

Reviewed-by: https://github.com/apps/ansible-zuul
 2021-03-05 17:49:45 +00:00
John R Barker
1822789d95
Merge branch 'main' into acldocs 2021-03-05 15:47:30 +00:00
John R Barker
ccbb679fc3
Formatting 2021-03-05 15:46:19 +00:00
Tadej Borovšak
98c86c54cd Inform synchronize module about community.docker collection 
The synchronize action plugin has a built-in list of connection
plugins that it knows how to handle.

One of those connection plugins is the docker connection plugin. And
because the docker content has been moved around quite a lot, the
docker connection plugin has quite a few names:

 - docker in Ansible 2.9,
 - community.general.docker for community.general < 2.0.0, and
 - community.docker.docker since a few months ago.

And while the synchronize module already knew about the first two
names, the last one was still missing. This commit fixes that omission
and adds a third name into the mix.
 2021-03-05 16:42:43 +01:00
Abhijeet Kasurde
ea8fc70373 Fix sanity test for modules 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2021-03-02 18:53:06 +05:30
Matt Perry
3043f737a0
Update ACL documentation 
Update ACL documentation to describe support for the `X` permission for the `setfacl` command.
 2021-02-25 11:40:32 -08:00
Evan Anderson
1e7d82af6d firewalld: Add support for firewalld port forwarding 
Fixes: ansible-collections/ansible.posix#100
 2021-01-16 19:05:44 -06:00