Pavel Bar
7bc21b6b41
Fix deprecated imports in tests/unit/modules/conftest.py
...
Replace deprecated module_utils imports:
- ansible.module_utils._text -> ansible.module_utils.common.text.converters
- ansible.module_utils.six.string_types -> str
- ansible.module_utils.common._collections_compat -> collections.abc
Fixes #686
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-02-15 23:56:05 +02:00
Pavel Bar
ab24f41cbd
Fix deprecated imports in tests/unit/mock/yaml_helper.py
...
Replace deprecated module_utils import:
- ansible.module_utils.six.PY3 -> removed (Python 2 code paths removed)
Related to #686
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-02-15 23:56:05 +02:00
Pavel Bar
b5c50b6881
Fix deprecated imports in tests/unit/mock/vault_helper.py
...
Replace deprecated module_utils import:
- ansible.module_utils._text -> ansible.module_utils.common.text.converters
Fixes #686
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-02-15 23:56:05 +02:00
Pavel Bar
0c210428cf
Fix deprecated imports in tests/unit/mock/procenv.py
...
Replace deprecated module_utils imports:
- ansible.module_utils._text -> ansible.module_utils.common.text.converters
- ansible.module_utils.six.PY3 -> removed (Python 2 code paths removed)
Fixes #686
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-02-15 23:56:05 +02:00
Pavel Bar
be431d23b5
Fix deprecated imports in tests/unit/mock/loader.py
...
Replace deprecated module_utils import:
- ansible.module_utils._text -> ansible.module_utils.common.text.converters
Fixes #686
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-02-15 23:56:05 +02:00
Pavel Bar
a9bdfed194
Fix deprecated imports in plugins/shell/fish.py
...
Replace deprecated module_utils imports:
- ansible.module_utils.six.text_type -> str
- ansible.module_utils.six.moves.shlex_quote -> shlex.quote
Fixes #686
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-02-15 23:56:05 +02:00
Pavel Bar
1d76c2ff5f
Fix deprecated imports in plugins/shell/csh.py
...
Replace deprecated module_utils imports:
- ansible.module_utils.six.text_type -> str
- ansible.module_utils.six.moves.shlex_quote -> shlex.quote
Fixes #686
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-02-15 23:56:05 +02:00
Pavel Bar
b8b424e4ee
Fix deprecated imports in plugins/modules/sysctl.py
...
Replace deprecated module_utils imports:
- ansible.module_utils._text -> ansible.module_utils.common.text.converters
- ansible.module_utils.six.string_types -> str
Fixes #686
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-02-15 23:56:05 +02:00
Pavel Bar
c669351777
Fix deprecated imports in plugins/callback/cgroup_perf_recap.py
...
Replace deprecated module_utils imports:
- ansible.module_utils._text -> ansible.module_utils.common.text.converters
- ansible.module_utils.six.with_metaclass -> Python 3 metaclass syntax
Fixes #686
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-02-15 22:56:50 +02:00
Pavel Bar
c1de972d38
Fix deprecated imports in plugins/modules/mount.py
...
Replace deprecated module_utils imports:
- ansible.module_utils._text -> ansible.module_utils.common.text.converters
- ansible.module_utils.six.iteritems -> dict.items()
Fixes #686
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-02-15 22:56:49 +02:00
Pavel Bar
1b079a3d17
Fix deprecated imports in plugins/action/synchronize.py
...
Replace deprecated module_utils imports:
- ansible.module_utils._text -> ansible.module_utils.common.text.converters
- ansible.module_utils.common._collections_compat -> collections.abc
- ansible.module_utils.six.string_types -> str
- ansible.module_utils.six.moves.shlex_quote -> shlex.quote
Fixes #686
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-02-15 22:56:49 +02:00
Hideki Saito
7d5aef07e2
Update AZP CI matrix and sanity test
...
* Update AZP CI matrix
* Add ignore file for Ansible Core 2.21
* Remove ignore lines for ansible-bad-import-from in 2.20 sanity tests
Signed-off-by: Hideki Saito <saito@fgrep.org>
2025-12-09 05:23:05 +00:00
Klaas Demter
9651a19805
change result.failed==True to result is failed in check_permissions.yml
...
Co-authored-by: Felix Fontein <felix@fontein.de>
2025-10-22 08:29:46 +02:00
Klaas Demter
413ab782a8
Fixes #462 notice permission denied on authorized_key module
2025-10-21 10:00:12 +02:00
saito-hideki
9dc73a686a
Ignore pylint errors caused by compatibility checks for six
...
* This is a temporary measure until we stop covering Python2
* Skipped sanity[cannot-ignore] to keep backward compatibility with Python2
* Consolidate all ansible-lint option locations into .ansible-lint
* Fixed some typos
Signed-off-by: saito-hideki <saito@fgrep.org>
2025-10-02 14:02:56 +09:00
saito-hideki
18e023dd77
Update AZP matrix to follow ansible-test changes
...
* https://github.com/ansible/ansible/pull/85558
* https://github.com/ansible/ansible/pull/85561
* https://github.com/ansible/ansible/pull/85562
Signed-off-by: saito-hideki <saito@fgrep.org>
2025-07-28 14:59:14 +09:00
saito-hideki
40c27e2bee
CI - bump ansible-core version
...
* bump devel to ansible-core 2.20
* add ansible-core 2.19 to stable list
Signed-off-by: saito-hideki <saito@fgrep.org>
2025-07-10 09:35:28 +09:00
saito-hideki
f977bffff2
[AZP] Add RHEL10 environment to CI matrix
...
* Fixes #642
Signed-off-by: saito-hideki <saito@fgrep.org>
2025-06-09 18:43:43 +09:00
Hideki Saito
7b9b1f4957
Fixes issue related to updating the ansible-core devel branch
...
* Fixes incorrect load path for json module in cgroup_perf_recap
* Remove unnecessary condition from seboolean integration tests
* Optimize conditions for selinux integration tests
* Fixes #630
Signed-off-by: Hideki Saito <saito@fgrep.org>
2025-04-17 00:11:31 +00:00
softwarefactory-project-zuul[bot]
f0b5f039d3
Merge pull request #613 from simonLeary42/rewrite-mount-tests
...
improve mount integration tests
SUMMARY
added check mode tests (assert no changes made)
added comments to make file less scary
ISSUE TYPE
tests
COMPONENT NAME
mount
ADDITIONAL INFORMATION
Reviewed-by: Abhijeet Kasurde
Reviewed-by: Hideki Saito <saito@fgrep.org>
2025-04-10 03:58:40 +00:00
Abhijeet Kasurde
eead50b287
Apply suggestions from code review
2025-03-26 12:36:08 -07:00
Simon Leary
4ff0e3aa13
remove assertion of changed
2025-03-26 15:20:42 -04:00
Simon Leary
979f00ce75
fix lint errors
2025-03-26 15:18:35 -04:00
Abhijeet Kasurde
d9f54eb9d4
[CI] update test containers
...
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2025-03-26 09:02:59 -07:00
Simon Leary
7d8da00f79
add (check mode) to task name
2025-03-06 10:46:57 -05:00
Simon Leary
f087d58cbe
fix bugs
2025-03-05 00:39:46 +00:00
Simon Leary
eb740e97d4
add check mode tests, add comments
2025-03-05 00:33:11 +00:00
Hideki Saito
6175a5028b
Change type of icmp_block_inversion option from str to bool
...
* Fixes #586
Signed-off-by: Hideki Saito <saito@fgrep.org>
2024-11-28 14:19:20 +09:00
Hideki Saito
8b611775d6
Changed the type of forward and masquerade options from str to bool
...
* Breaking Change
* Fixes #582
Signed-off-by: Hideki Saito <saito@fgrep.org>
2024-10-31 16:06:10 +09:00
Hideki Saito
2f095566c7
Modify conditions for selinux integratuion tests
...
Signed-off-by: Hideki Saito <saito@fgrep.org>
2024-10-15 17:15:51 +09:00
copyrights
2041e7f918
mount: remove boot exception if defaults in opts
2024-10-04 14:39:04 +09:00
softwarefactory-project-zuul[bot]
0821768bcb
Merge pull request #568 from abakanovskii/feature/add_path_option_authorized_key
...
authorized_key: Allow local path to a key
SUMMARY
Add option to specify an absolute path to file with SSH key(s) for authorized_key
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
authorized_key
ADDITIONAL INFORMATION
Before this change you would need to get key using ansible.builtin.slurp or something like ansible.builtin.command: cat <file> with register
I tried to keep it as simple as possible
# Now this is possible
- name: Set authorized keys taken from path
ansible.posix.authorized_key:
user: charlie
state: present
key: /home/charlie/.ssh/id_rsa.pub
Reviewed-by: Hideki Saito <saito@fgrep.org>
Reviewed-by: alexander
2024-09-30 07:07:25 +00:00
Александр Бакановский
5f3f8514eb
Allow remote path for authorized_key
2024-09-30 09:40:03 +03:00
Hideki Saito
7194b6bb13
CI - bump ansible-core version
...
* bump devel test to ansible-core 2.19
* add ansible-core 2.18 to stable list but CI only covers sanity test at the moment.
Signed-off-by: Hideki Saito <saito@fgrep.org>
2024-09-25 09:37:42 +09:00
softwarefactory-project-zuul[bot]
d968ac441e
Merge pull request #563 from dtvillafana/main
...
(feat) add no_log option for 'opts' parameter
SUMMARY
Allows you to set no_log on just the opts parameter.
This is useful for CIFS/SMB mounts that would otherwise leak secrets.
Adds feature from issue: . #497
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
mount
Reviewed-by: Hideki Saito <saito@fgrep.org>
2024-09-11 02:27:00 +00:00
dvillafana
e00a4299c1
(feat) add no_log options for 'opts' parameter
...
* Fixed #497
2024-09-11 11:04:16 +09:00
Gerlof Fokkema
257392f33d
Firewalld: Add functionality to set forwarding. Fixes #529 .
2024-09-09 15:13:12 +09:00
Felix Fontein
a615b84bf7
Add sanity ignore file for ansible-core devel 2.18.
2024-06-07 07:12:06 +02:00
Jill Rouleau
83c4d2abd1
lint fixes
2024-05-09 12:10:44 -07:00
Jill Rouleau
e5733c5e49
Quote string in test assertion
2024-05-07 16:53:57 -07:00
Jill Rouleau
d49bd27fae
Revert "sysctl: Fixed sysctl to work on symlinks( #111 )"
...
This reverts commit 34b467719e .
2024-05-07 16:53:57 -07:00
satken2
9064ff7eb2
sysctl: Fixed sysctl to work on symlinks( #111 )
2024-05-07 16:53:57 -07:00
satken2
a842e5f96a
sysctl: Fixed sysctl to work on symlinks( #111 )
2024-05-07 16:53:57 -07:00
satken2
97dcdee670
sysctl: Fixed sysctl to work on symlinks( #111 )
2024-05-07 16:53:57 -07:00
satken2
55ea4ba1de
sysctl: Fixed sysctl to work on symlinks( #111 )
2024-05-07 16:53:57 -07:00
Hideki Saito
ac82f575c6
Replaced yield with yield from to address latest sanity test
...
Signed-off-by: Hideki Saito <saito@fgrep.org>
2024-03-26 13:54:40 +09:00
Hideki Saito
4f93234a8b
Replaced old selogin FQCN
...
- FCQN has been changed since comunity.general stable-6
Signed-off-by: Hideki Saito <saito@fgrep.org>
2024-03-26 10:39:34 +09:00
Felix Fontein
45d8819b7c
Remove Shippable leftovers.
2024-01-09 07:25:45 +01:00
softwarefactory-project-zuul[bot]
2c52f969e1
Merge pull request #484 from flowerysong/firewalld_offline
...
firewalld: make offline do something
SUMMARY
ansible.posix.firewalld has an offline flag, but it currently does not do anything. What most people expect it to do is allow the task to proceed even when firewalld is offline, so it makes the most sense for it to override the immediate flag and prevent the module from throwing an error in that case.
Fixes #81 .
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
firewalld
ADDITIONAL INFORMATION
Reviewed-by: Adam Miller <admiller@redhat.com>
2023-12-07 21:18:29 +00:00
Adam Miller
a85f736f6a
refactor to comply with current ansible-lint and sanity guidelines
...
Signed-off-by: Adam Miller <admiller@redhat.com>
2023-12-06 17:22:59 -06:00