changelogs/fragments/451_firewall_fix_protocol_parameter.yml

@@ -1,3 +0,0 @@
----
-bugfixes:
-  - firewall - Fix issue where opening a specific port resulted in opening the whole protocol of the specified port

plugins/modules/firewalld.py

@@ -856,16 +856,15 @@ def main():
     zone = module.params['zone']
     target = module.params['target']
 
-    port = None
     if module.params['port'] is not None:
         if '/' in module.params['port']:
-            port, port_protocol = module.params['port'].strip().split('/')
+            port, protocol = module.params['port'].strip().split('/')
         else:
-            port_protocol = None
-        if not port_protocol:
+            protocol = None
+        if not protocol:
             module.fail_json(msg='improper port format (missing protocol?)')
     else:
-        port_protocol = None
+        port = None
 
     port_forward_toaddr = ''
     port_forward = None
@@ -982,7 +981,7 @@ def main():
 
         transaction = PortTransaction(
             module,
-            action_args=(port, port_protocol, timeout),
+            action_args=(port, protocol, timeout),
             zone=zone,
             desired_state=desired_state,
             permanent=permanent,
@@ -994,7 +993,7 @@ def main():
         if changed is True:
             msgs.append(
                 "Changed port %s to %s" % (
-                    "%s/%s" % (port, port_protocol), desired_state
+                    "%s/%s" % (port, protocol), desired_state
                 )
             )