Merge 2990582b41 into 6473053b13

add changelog 504-firewalld_info-warning
warn only when zones were ignored
2026-01-12 23:55:19 +01:00 · 2024-01-08 20:30:10 +00:00 · 2023-12-16 18:53:39 +01:00 · 2023-12-16 18:53:39 +01:00
2 changed files with 5 additions and 2 deletions
--- a/changelogs/fragments/504-firewalld_info-warning.yaml
+++ b/changelogs/fragments/504-firewalld_info-warning.yaml
@ -0,0 +1,2 @@
+minor_changes:
+  - firewalld_info - Only warn about ignored zones, when there are zones ignored.
--- a/plugins/modules/firewalld_info.py
+++ b/plugins/modules/firewalld_info.py
@ -356,8 +356,9 @@ def main():
            specified_zones = module.params['zones']
            collect_zones = list(set(specified_zones) & set(all_zones))
            ignore_zones = list(set(specified_zones) - set(collect_zones))
-            warn.append(
-                'Please note: zone:(%s) have been ignored in the gathering process.' % ','.join(ignore_zones))
+            if ignore_zones:
+                warn.append(
+                    'Please note: zone:(%s) have been ignored in the gathering process.' % ','.join(ignore_zones))
        else:
            collect_zones = get_all_zones(client)
Author	SHA1	Message	Date
Michael	25d8db7473	Merge `2990582b41` into `6473053b13`	2024-01-08 20:30:10 +00:00
mib1185	2990582b41	add changelog 504-firewalld_info-warning	2023-12-16 18:53:39 +01:00
Michael	42f7d48d73	warn only when zones were ignored	2023-12-16 18:53:39 +01:00