Merge 230e5f2a98 into 0847977d12

changelogs/fragments/421-remove-deprecation-warning.yml

@@ -1,2 +0,0 @@
-trivial:
-  - synchronize - instantiate the connection plugin without the ``new_stdin`` argument, which is deprecated in ansible-core 2.15 (https://github.com/ansible-collections/ansible.posix/pull/421).

plugins/action/synchronize.py

@@ -284,6 +284,9 @@ class ActionModule(ActionBase):
         # told (via delegate_to) that a different host is the source of the
         # rsync
         if not use_delegate and remote_transport:
+            # Create a connection to localhost to run rsync on
+            new_stdin = self._connection._new_stdin
+
             # Unlike port, there can be only one shell
             localhost_shell = None
             for host in C.LOCALHOST:
@@ -312,11 +315,7 @@ class ActionModule(ActionBase):
                 localhost_executable = C.DEFAULT_EXECUTABLE
             self._play_context.executable = localhost_executable
 
-            try:
+            new_connection = connection_loader.get('local', self._play_context, new_stdin)
-                new_connection = connection_loader.get('local', self._play_context)
-            except TypeError:
-                # Needed for ansible-core < 2.15
-                new_connection = connection_loader.get('local', self._play_context, self._connection._new_stdin)
             self._connection = new_connection
             # Override _remote_is_local as an instance attribute specifically for the synchronize use case
             # ensuring we set local tmpdir correctly