Merge pull request #420 from austlane/bindep-centos

bindep - install rsync on all EL variants Adds support for installing rsync for centos and related EL variants (AlmaLinux, Rocky, Oracle, etc) rsync is an extremely common package, available in the base repos of all EL distros. This is necessary to properly support AWX-EE and other community-built EL Execution Environments. See: ansible/awx-ee#167 Reviewed-by: Austin Lane <austinwlane@gmail.com> Reviewed-by: Hideki Saito <saito@fgrep.org>
Merge pull request #426 from exploide/firewalld_info_docs
2026-01-11 15:15:26 +01:00 · 2023-03-24 07:26:17 +00:00 · 2023-03-24 06:51:24 +00:00 · 2023-03-24 06:11:30 +00:00 · 2023-03-23 17:31:31 -06:00 · 2023-03-23 15:52:20 -06:00
5 changed files with 15 additions and 3 deletions
--- a/bindep.txt
+++ b/bindep.txt
@ -1,4 +1,4 @@
 # This is a cross-platform list tracking distribution packages needed by tests;
 # see https://docs.openstack.org/infra/bindep/ for additional information.

-rsync [platform:rhel-8 platform:rhel-9]
+rsync [platform:redhat]
--- a/changelogs/fragments/426-firewalld_info-doc-update.yml
+++ b/changelogs/fragments/426-firewalld_info-doc-update.yml
@ -0,0 +1,4 @@
+---
+
+trivial:
+  - firewalld_info - fixed typo in return value and improved examples in documentation
--- a/changelogs/fragments/434-fix-rhel_facts-exit_json.yml
+++ b/changelogs/fragments/434-fix-rhel_facts-exit_json.yml
@ -0,0 +1,2 @@
+bugfixes:
+  - rhel_facts - Call exit_json with all keyword arguments
--- a/plugins/modules/firewalld_info.py
+++ b/plugins/modules/firewalld_info.py
@ -37,6 +37,11 @@ EXAMPLES = r'''
 - name: Gather information about active zones
  ansible.posix.firewalld_info:
    active_zones: true
+  register: result
+
+- name: Print default zone for debugging
+  ansible.builtin.debug:
+    var: result.firewalld_info.default_zone

 - name: Gather information about specific zones
  ansible.posix.firewalld_info:
@ -44,6 +49,7 @@ EXAMPLES = r'''
      - public
      - external
      - internal
+  register: result
 '''

 RETURN = r'''
@ -78,7 +84,7 @@ firewalld_info:
            returned: success
            type: str
            sample: 0.8.2
-        default_zones:
+        default_zone:
            description:
              - The zone name of default zone.
            returned: success
--- a/plugins/modules/rhel_facts.py
+++ b/plugins/modules/rhel_facts.py
@ -69,7 +69,7 @@ def main():
    if os.path.exists("/run/ostree-booted"):
        ansible_facts['pkg_mgr'] = 'ansible.posix.rhel_rpm_ostree'

-    module.exit_json(ansible_facts, changed=False)
+    module.exit_json(ansible_facts=ansible_facts, changed=False)


 if __name__ == '__main__':
Author	SHA1	Message	Date
softwarefactory-project-zuul[bot]	1eb594b836	Merge pull request #420 from austlane/bindep-centos bindep - install rsync on all EL variants Adds support for installing rsync for centos and related EL variants (AlmaLinux, Rocky, Oracle, etc) rsync is an extremely common package, available in the base repos of all EL distros. This is necessary to properly support AWX-EE and other community-built EL Execution Environments. See: ansible/awx-ee#167 Reviewed-by: Austin Lane <austinwlane@gmail.com> Reviewed-by: Hideki Saito <saito@fgrep.org>	2023-03-24 07:26:17 +00:00
softwarefactory-project-zuul[bot]	f47c5d6039	Merge pull request #426 from exploide/firewalld_info_docs firewalld_info: fixed typo in default_zone and improved examples SUMMARY There was a typo in the docs of firewalld_info. Furthermore I slightly improved the examples by showcasing how to use the data gathered by this module. ISSUE TYPE Docs Pull Request COMPONENT NAME firewalld_info ADDITIONAL INFORMATION I'm not sure whether I should also update the file docs/ansible.posix.firewalld_info_module.rst but I suspect it will be generated automatically? Reviewed-by: Hideki Saito <saito@fgrep.org>	2023-03-24 06:51:24 +00:00
softwarefactory-project-zuul[bot]	ab94cc7294	Merge pull request #434 from richm/fix-rhel_facts-issue rhel_facts module must use keyword arguments SUMMARY The rhel_facts module must use keyword arguments. The current code gives this error: Traceback (most recent call last): ... File "/tmp/ansible_ansible.posix.rhel_facts_payload_y10oy_4m/.../rhel_facts.py", line 72, in main TypeError: exit_json() takes 1 positional argument but 2 were given The fix is to use all keyword arguments like other facts plugins. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ansible.posix.rhel_facts ADDITIONAL INFORMATION @maxamillion fyi Reviewed-by: Hideki Saito <saito@fgrep.org>	2023-03-24 06:11:30 +00:00
Rich Megginson	0e92d30fd3	add changelog fragment	2023-03-23 17:31:31 -06:00
Rich Megginson	583e4a6d6b	rhel_facts module must use keyword arguments The rhel_facts module must use keyword arguments. The current code gives this error: ``` Traceback (most recent call last): ... File "/tmp/ansible_ansible.posix.rhel_facts_payload_y10oy_4m/.../rhel_facts.py", line 72, in main TypeError: exit_json() takes 1 positional argument but 2 were given ``` The fix is to use all keyword arguments like other facts plugins.	2023-03-23 15:52:20 -06:00
exploide	01f19cde25	firewalld_info: fixed typo in default_zone and improved examples	2023-03-14 18:53:36 +01:00
austlane	94523978d2	bindep - install rsync on all EL variants Adds support for installing rsync for centos and related EL variants (AlmaLinux, Rocky, Oracle, etc) rsync is an extremely common package, available in the base repos of all EL distros This is necessary to properly support AWX-EE and other community-built EL Execution Environments.	2023-02-22 20:07:25 -05:00